Ruby: Add query for access paths in model editor#15503
Merged
Conversation
hmac
previously approved these changes
Feb 5, 2024
hmac
approved these changes
Feb 5, 2024
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple query for creating a subset of valid access paths that can be used in MaD models. It's not intended to be complete, and will probably be rewritten to be a recursive query rather than this simple query.
Considerations:
nodesandedgesquery predicates), but we want to get this simple solution in first.Util::pathToNodedoes something close to what we want, but it doesn't have thedetailsanddefType, which are really useful to have in the model editor.It seems like the query is also reporting
Argument[self]for for exampledef self.self_foo. Does this make sense? It seems like the method node does return the parameter fromgetSelfParameter.